Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a package using our latest template - interesting dependency tree? #669

Closed
ErikEJ opened this issue Dec 17, 2024 · 1 comment · Fixed by #670
Closed

Created a package using our latest template - interesting dependency tree? #669

ErikEJ opened this issue Dec 17, 2024 · 1 comment · Fixed by #670
Labels
bug Something isn't working

Comments

@ErikEJ
Copy link
Collaborator

ErikEJ commented Dec 17, 2024

@jmezach Created a package using our latest template - interesting dependency tree?

Maybe we should improve this in the SDK or the template?

Image

That sounds like a bug in MSBuild.Sdk.SqlProj that we should probably fix.

Originally posted by @jmezach in CommunityToolkit/Aspire#327 (comment)
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Dec 17, 2024

@jmezach I think it actually an issue with my analyzer packages. I will attempt a fix, and make template and docs updates here...

@ErikEJ ErikEJ added the bug Something isn't working label Dec 17, 2024
ErikEJ added a commit to ErikEJ/MSBuild.Sdk.SqlProj that referenced this issue Dec 17, 2024
@ErikEJ
Update template and readme
9f552ea 
fixes rr-wfm#669
@ErikEJ ErikEJ mentioned this issue Dec 17, 2024
Merged
@ErikEJ ErikEJ closed this as completed in e5b2557 Dec 18, 2024
ErikEJ added a commit to ErikEJ/DacFx that referenced this issue Dec 18, 2024
@ErikEJ
Use DevelopmentDependency
56a2437 
see rr-wfm/MSBuild.Sdk.SqlProj#669
@ErikEJ ErikEJ mentioned this issue Dec 18, 2024
Merged
zijchen pushed a commit to microsoft/DacFx that referenced this issue Dec 19, 2024
@ErikEJ
Use DevelopmentDependency (#546)
6f804fb 
see rr-wfm/MSBuild.Sdk.SqlProj#669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update template and readme ErikEJ/MSBuild.Sdk.SqlProj
1 participant
@ErikEJ