Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix issue with extra command line arguments #501

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Jan 11, 2024

fixes #500

@jmezach
Copy link
Member

jmezach commented Jan 11, 2024

Can we test that this actually fixes something?

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jan 11, 2024

If we build a preview package that the OP can consume in his pipeline?

@jmezach
Copy link
Member

jmezach commented Jan 11, 2024

Sure. I can upload the preview package to NuGet.org tomorrow.

@jmezach
Copy link
Member

jmezach commented Jan 15, 2024

Turned out to be really busy last Friday so I didn't get around to it. But I've uploaded a pre-release version of this PR to NuGet.org which should be available soon. Version 2.7.0-beta.30.g42c33ba1c7.

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jan 15, 2024

@popcatalin81 Are you able to test this preview package in your pipeline?

https://www.nuget.org/packages/MSBuild.Sdk.SqlProj/2.7.0-beta.30.gf2c33ba1c7

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jan 22, 2024

@popcatalin81 Ping?

@popcatalin81
Copy link

@popcatalin81 Ping?

Yes, I will test right away. I was ooo for the past week.

@popcatalin81
Copy link

@ErikEJ This took longer than I wanted it too due to some big changes to the project pipeline that made the whole CI be offline for the past weeks.

However I can confirm now the fix worked.

@jmezach jmezach merged commit 9ed45e6 into rr-wfm:master Feb 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecognized command or argument '-p:UseSharedCompilation=false' when running on Github build
4 participants