Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "bring your own rules" (or update existing) #533

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Mar 7, 2024

fixes #530

@ErikEJ ErikEJ requested review from jeffrosenberg and jmezach March 7, 2024 08:10
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/DacpacTool/DacpacTool.csproj Show resolved Hide resolved
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Mar 7, 2024

@jeffrosenberg Do you also have time to look at this 🙏

Copy link
Collaborator

@jeffrosenberg jeffrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a couple of small comments

src/DacpacTool/PackageAnalyzer.cs Show resolved Hide resolved
src/DacpacTool/PackageBuilder.cs Outdated Show resolved Hide resolved
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Mar 7, 2024

@jeffrosenberg Thanks for your review - I believe I have addressed the comments now

@ErikEJ ErikEJ merged commit d917489 into rr-wfm:master Mar 7, 2024
13 checks passed
jmezach pushed a commit that referenced this pull request Mar 11, 2024
* Add support for "bring your own rules" (or update existing)

fixes #530

* PR updates
@ErikEJ ErikEJ mentioned this pull request Sep 24, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to update current rules or bring your own
3 participants