Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 9 and remove .NET 6 #634

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Use .NET 9 and remove .NET 6 #634

merged 5 commits into from
Oct 28, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Oct 5, 2024

part of #630

Need to open in VS 17.12

src/DacpacTool/DacpacTool.csproj Outdated Show resolved Hide resolved
test/DacpacTool.Tests/DacpacTool.Tests.csproj Outdated Show resolved Hide resolved
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 23, 2024

@jmezach Should I convert this to non draft. so we maybe can get a 3.0 preview out?

@jmezach
Copy link
Member

jmezach commented Oct 23, 2024

Yeah, that sounds good. Haven't found the time to look at removing our dependency on the submodule unfortunately.

@ErikEJ ErikEJ marked this pull request as ready for review October 23, 2024 08:00
@ErikEJ ErikEJ requested a review from jmezach October 23, 2024 08:00
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 23, 2024

Haven't found the time to look at removing our dependency on the submodule unfortunately.

Maybe that was a bit too ambitious? 😄

@jmezach jmezach mentioned this pull request Oct 28, 2024
4 tasks
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmezach jmezach merged commit e4434e1 into rr-wfm:master Oct 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants