-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI prints project version number #428
Conversation
Vue Mess Detector Analysis Results🚨 New Errors: 0 New Issues
🔍 Download Full Analysis Details For any issues or feedback, feel free to report them here. |
commit: |
Vue Mess Detector Analysis Results🚨 New Errors: 0 New Issues
🔍 Download Full Analysis Details For any issues or feedback, feel free to report them here. |
I'm struggling with these failing tests, locally without any changes they are mostly timing out even when set to 20 seconds, feel free to make grand sweeping changes @David-Pena |
Vue Mess Detector Analysis Results🚨 Errors: 68 Issues
🔍 Download Full Analysis Details For any issues or feedback, feel free to report them here. |
Vue Mess Detector Analysis Results🚨 Errors: 68 Issues
🔍 Download Full Analysis Details For any issues or feedback, feel free to report them here. |
@David-Pena or @rrd108 this is ready for a review. Please do check it out and give it a waltz yourselves since I still couldn't get any cli tests to run locally after a bunch of changes so 🤷 |
On my end I have similar issues with the tests in another branch (still trying to figure out why) probably @rrd108 can check it out soon |
I see all checks have passed @pieterocp |
Sorry for not replying, I was (I am) sick. I do not think that changing the tests is needed here. I think the bug sits somewhere else. |
Don't apologise, I hope you get better soon.
Yeah, does sound like it, if this isn't working then feel free to close this PR. |
Let me investigate it further. |
Hi @pieterocp I found and fixed this issue locally, it was happening because the flag was retrieving the Would you like me to push my code to your branch so we can move forward this PR? Or would you like to give a try? |
Go for it @David-Pena, thank you. |
Got it! I'll push it in a moment 🫡 |
This PR will be closed, the fix is in #461 |
Summary
Gets version printing out project specific version number. Helpful for bug reports/checking versions at a glance.
Description
Should get the version number printing. Still need to pull it into a project and test but I want to say this does it.
Related Issues
Fixes #427
Type of Change
Screenshots (if applicable)