Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move repository package to new module #8

Open
rreganjr opened this issue Mar 6, 2018 · 1 comment
Open

move repository package to new module #8

rreganjr opened this issue Mar 6, 2018 · 1 comment
Assignees
@rreganjr
Labels
refactor non-functional code changes
Milestone
1.0.3

Comments

@rreganjr
Copy link
Owner

rreganjr commented Mar 6, 2018

No description provided.

@rreganjr rreganjr added the refactor non-functional code changes label Mar 6, 2018
@rreganjr rreganjr added this to the 1.0.3 milestone Mar 6, 2018
@rreganjr rreganjr self-assigned this Mar 19, 2018
rreganjr added a commit that referenced this issue Mar 19, 2018
@rreganjr
https://github.com/rreganjr/Requel/issues/7
e07df7c 
#8
#13
#15
branch 1.0.3

I added exception module and moved some exceptions to it, I removed RequelException and just use ApplicationException isntead. most are at the root level com.rreganjr.
I added initializer module and moved the SystemInitializer and AbstractSystemInitializer to it. I split this because both nlp and requel use it.
I added repository module and moved the repository package to it. I split this because both nlp and requel use it.
I added nlp module and moved the nlp package to it.

I removed the UserSet/UserSetImpl and replaced with Set<User> and TreeSet<User>

Signed-off-by: rreganjr <rreganjr@acm.org>
@rreganjr
Copy link
Owner Author

branch 1.0.3

I added exception module and moved some exceptions to it, I removed RequelException and just use ApplicationException isntead. most are at the root level com.rreganjr.
I added initializer module and moved the SystemInitializer and AbstractSystemInitializer to it. I split this because both nlp and requel use it.
I added repository module and moved the repository package to it. I split this because both nlp and requel use it.
I added nlp module and moved the nlp package to it.

I removed the UserSet/UserSetImpl and replaced with Set and TreeSet

rreganjr added a commit that referenced this issue Apr 18, 2018
@rreganjr
https://github.com/rreganjr/Requel/issues/7
bd200ae 
#8
#9
#10
#11
#12
branch 1.0.3

I had to make more modules than originally expected to get around some cyclic dependencies, but there are still some issues, new bugs created. see #16

Signed-off-by: rreganjr <rreganjr@acm.org>
rreganjr added a commit that referenced this issue Jun 13, 2018
@rreganjr
https://github.com/rreganjr/Requel/issues/7
7160966 
#8
#9
#10
#11
#12
branch 1.0.3

Moved properties for UI and NLP into appropriate modules. updated discriminator value in XML files to use the simple name of the role subclasses without the pathname

Signed-off-by: rreganjr <rreganjr@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rreganjr rreganjr

Labels
refactor non-functional code changes
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
1 participant
@rreganjr