Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my previous PRs failed the hassfest validation on existing code. This change should bring that code in line with the hassfest checks.
manifest.json
by addingtag
toafter_dependencies
. It was triggered because offrom homeassistant.components.tag import async_scan_tag
in__init__.py
. Added theafter_dependencies
makes sure that the home assistant tag component is loaded before the Dahua integration.manifest.json
as "Manifest keys should be sorted: domain, name, then alphabetical order"services.yaml
by adding a name attribute to the mentioned fields.__init__.py
by removingasync_setup
as its not implemented and YAML setup is not supported