Auto-detect language from filename #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e translation patch and not the UI language
- Includes tests for various filenames - Updates the docs
|
Awesome! Great work again. Thanks so much for your contributions. This is exactly how I envisioned the auto-detection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, the implementation for the auto-detection of the translation patch from the filename. It is using regular expressions to get the job done. #9 (comment)
First of all, the label of the language combo box was changed to "translation patch" in order to make it more clear that not the UI language is being selected but the translation of the ROM. Also, the list of translations was updated to show more details.
For the UI, one may select the newly added "auto" option from the language combo box. Selecting any of the other options forces to manually select that language. This is useful in cases where the auto-detection fails.
The docs have also been updated which explain the order in which the language is being detected in more detail.
Tests have been added for the most common filenames.
Lastly, the save button is being disabled now in case loading a save file fails.