Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make useCallback hook's keys optional #369

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

jezsung
Copy link
Contributor

@jezsung jezsung commented Jul 10, 2023

Makes the useCallback hook's keys property optional and default to an empty list.

@rrousselGit
Copy link
Owner

Thanks!
Could you add a test for this too? 🙏

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a6b45c) 99.87% compared to head (3558a74) 99.87%.

❗ Current head 3558a74 differs from pull request most recent head 258b69e. Consider uploading reports for the commit 258b69e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          18       18           
  Lines         775      775           
=======================================
  Hits          774      774           
  Misses          1        1           
Impacted Files Coverage Δ
packages/flutter_hooks/lib/src/primitives.dart 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jezsung
Copy link
Contributor Author

jezsung commented Jul 10, 2023

@rrousselGit Sure, should I also upgrade the version to 0.18.7?

@rrousselGit
Copy link
Owner

No, I bump versions myself

@rrousselGit
Copy link
Owner

LGTM, thanks!

@rrousselGit rrousselGit merged commit 81c7833 into rrousselGit:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants