Add useOnListenableChange

[timcreatedit]

Fixes #326
(potentially, people can just call .value for ValueListenables, so I would argue an extra hook isn't needed
Fixes #389

[changeset-bot]

⚠️ No Changeset found

Latest commit: f2812a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[rrousselGit]

That's not very efficient. It'd usually add/remove a listener whenever the build method updates.
We should have a listener method on the Hook class.

Of course we'd need a test for that too :)

[timcreatedit]

Hmm you're right, I never thought about that, most people are going to use it with anonymous functions. Time to refactor all my codebases that use callbacks in hooks as well 😅

[timcreatedit]

I've updated it, I'm not quite sure if this is what you meant, but it seems to work

[rrousselGit]

The issue isn't the anonymous function. It's your didUpdateHook implementation.

Like I said, you could have:

class A extends Hook {
  void listener() {
    hook.listener();
  }

  initHook() {
    listenable.addListener(listener);
  }
  dispose() {
    listenable.removeListener(listener);
  }
}

[timcreatedit]

Thanks for the feedback, however, I honestly can't quite make sense of what you're saying.

Both your previous comment, as well as this one refer to having a listener method on the hook class, however your pseudo-example calls hook.listener() from inside a Hook not a HookState, which must be a mistake.

I'm therefore assuming you meant to write extends HookState. It makes sense to optimize listener changes like this, which is what I did on the most recent commits, but I'm failing to see how this would update whenever the Hook's listenable changes?

[rrousselGit]

Tests are still passing, aren't they? ;)

this.hook was mutated when didUpdateHook was called. So the HookState.listener method points to the new callback.

[timcreatedit]

I think there's a misunderstanding. If you agree with the latest implementation on this branch, we're on the same page. I was under the assumption that you want to get rid of the entire didUpdateHook method as well. That's the part that doesn't make sense to me.

[timcreatedit]

If the only parts where the listener is added and removed are initHook and dispose respectively, which is what I thought you were pointing at, tests don't pass anymore.

[timcreatedit]

@rrousselGit, I was wondering whether we were on the same page now or if you expect me to do anything still? Just wanted to touch base since I don't know if, and which changes you are proposing, so I'm currently not working on anything 😅

[rrousselGit]

Sorry, my bad.

LGTM, but do you mind adding it in the README?

[timcreatedit]

LGTM, but do you mind adding it in the README?

It's added to the "Listenable related hooks:" table, would you want it somewhere else?

[rrousselGit]

Ah dang it, I didn't see the file.
It's good. Thanks!