Fix warning for Credo.Check for Elixir 1.18

Fixes a warning that some generated clauses weren't called in a static test case
rrrene · Dec 13, 2024 · 91502ce · 91502ce
1 parent d4b9901
commit 91502ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/credo/check.ex b/lib/credo/check.ex
@@ -457,11 +457,7 @@ defmodule Credo.Check do
 
       defoverridable Credo.Check
 
-      defp append_issues_and_timings([] = _issues, exec) do
-        exec
-      end
-
-      defp append_issues_and_timings([_ | _] = issues, exec) do
+      defp append_issues_and_timings(issues, exec) do
         Credo.Execution.ExecutionIssues.append(exec, issues)
       end
     end

diff --git a/lib/credo/execution/execution_issues.ex b/lib/credo/execution/execution_issues.ex
@@ -14,6 +14,8 @@ defmodule Credo.Execution.ExecutionIssues do
   end
 
   @doc "Appends an `issue` for the specified `filename`."
+  def append(_, [] = _issues), do: :ok
+
   def append(%Execution{issues_pid: pid}, issues) when is_list(issues) do
     issues
     |> Enum.group_by(& &1.filename)