Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnusedVariableNames missing checks #1166

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Wigny
Copy link

@Wigny Wigny commented Dec 9, 2024

While solving ours {Credo.Check.Consistency.UnusedVariableNames, [force: :meaningful]} check issues, I noticed that many cases were not being caught by the check, such as:

# match in tuples
{:ok, _} = fun1()

# match inside `with`
with {:ok, _} <- fun1(), do: :ok

# match in lists
def fun2([_ | _]) do
end

# for macros 
defmacro __using__(_) do
end

This MR adds the missing checks I could notice, so feel free to add/point any other cases we could still be missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant