Fix Credo.Check.Refactor.Apply #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrene
reviewed
Oct 14, 2021
Comment on lines
58
to
62
| test "it should report a violation for apply/2" do | ||
| """ | ||
| defmodule Test do | ||
| def some_function(fun, arg1, arg2) do | ||
| apply(fun, [arg1, arg2]) | ||
| def some_function(arg1, arg2) do | ||
| apply(:fun_name, [arg1, arg2]) |
There was a problem hiding this comment.
Why do we need to update this particular test in a PR fixing #892?
There was a problem hiding this comment.
The new test above replaced these tests, and this test is now one of the two tests for testing that the check reports a violation. The check reports now just a violation when fun_name is an atom and args is a list. The mentioned test is testing this now for apply/2.
There was a problem hiding this comment.
But there is no longer a test ensuring that apply/2 works with a variable given for the fun name? Or am I missing something?
There was a problem hiding this comment.
Ah, now I see. I will add some more tests for apply/2.
|
@NickNeck Thx! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #892