Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User roles are not checked #14

Open
rrrnld opened this issue Jul 13, 2018 · 1 comment
Open

User roles are not checked #14

rrrnld opened this issue Jul 13, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@rrrnld
Copy link
Owner

rrrnld commented Jul 13, 2018

Before implementing sharing, playlists etc, we should take user roles into consideration. My idea would be to use http://www.subsonic.org/pages/api.jsp#getUser for authenticating on login and saving the roles locally.
@rrrnld rrrnld added the bug Something isn't working label Jul 13, 2018
rrrnld added a commit that referenced this issue Sep 5, 2018
@rrrnld
Add user role checks, see #14
5cbb83a 
Squashed commit of the following:

commit 393c481a21fa97881be2b6859e9acaa8ab7abb7f
Author: Arne Schlüter <arne@schlueter.is>
Date:   Wed Sep 5 12:04:56 2018 +0200

    Consider user roles when building up the navigation

commit d631cba1174ecf42b682664bf57c41b88b7f5ed4
Author: Arne Schlüter <arne@schlueter.is>
Date:   Wed Sep 5 11:52:05 2018 +0200

    Save user roles on login

commit e68ced335ccc11a2daebbf12bb4061a53935c268
Author: Arne Schlüter <arne@schlueter.is>
Date:   Wed Sep 5 10:25:19 2018 +0200

    Rename dispatch to muted-dispatch for easier disambiguation
@rrrnld
Copy link
Owner Author

rrrnld commented Sep 5, 2018 •
edited
Loading

User role checks have been implemented and the UI displays different elements for different access rights, however they are not yet checked at all in the client side routing. This is partially because client-side routing might completely change with the new release of reitit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rrrnld