-
Notifications
You must be signed in to change notification settings - Fork 0
Server url relative #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oyed to multiple domains
|
| console.error( | ||
| 'rrweb-cloud: Unable to start(); sessionStorage unavailable', | ||
| ); | ||
| // eslint-ignore-next-line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I gave you the incorrect syntax for this. Here is a description of all the options you have with regards to this: https://byby.dev/eslint-disable-rules
It's good practice to add the case you are ignoring for as well.
eg. // eslint-disable-next-line no-empty-catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, yes I hope this one qualifies as it's a 'hook' to the name of some global emit function they are specifying. It's all speculative at this stage.
…e>['emit']` but it didn't work as the emit parameter is optional
…to check the hostname
…hat we handle it as it could get similarly mangled at a different stage
…things tried: - (window[configEmit] as typeof recordOptions.emit)(event); - (window[configEmit] as recordOptions<eventwithTime>['emit'])(event); // didn't work as the emit parameter is optional
Allow relative urls in the case where a single build needs to be deployed to multiple domains