Skip to content

Conversation

@eoghanmurray
Copy link
Collaborator

Allow relative urls in the case where a single build needs to be deployed to multiple domains

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

⚠️ No Changeset found

Latest commit: 7dc3965

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

console.error(
'rrweb-cloud: Unable to start(); sessionStorage unavailable',
);
// eslint-ignore-next-line
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I gave you the incorrect syntax for this. Here is a description of all the options you have with regards to this: https://byby.dev/eslint-disable-rules

It's good practice to add the case you are ignoring for as well.
eg. // eslint-disable-next-line no-empty-catch

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes I hope this one qualifies as it's a 'hook' to the name of some global emit function they are specifying. It's all speculative at this stage.

…e>['emit']` but it didn't work as the emit parameter is optional
…hat we handle it as it could get similarly mangled at a different stage
…things tried:

 - (window[configEmit] as typeof recordOptions.emit)(event);
 - (window[configEmit] as recordOptions<eventwithTime>['emit'])(event); // didn't work as the emit parameter is optional
@eoghanmurray eoghanmurray merged commit 34bad60 into master Dec 4, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants