nested record iframe #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this implementation, we add a root id to the serialized node when its target document is not the top scope document object. Currently we do not rely on the root id in rebuilding, but has an assertion to make sure we are handling this right. BTW, iframe contentDocument will only be available when it was append to the DOM tree. Since we are building nodes recursively, we put iframe stuffs into a callback array which will execute after the whole rebuilding.
|
跨域的情况下应该记录不到吧? |
|
@wuzekang 是的，这也是一直没有 merge 的原因 |
|
things go to #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.