Make block css class optional & fix test #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuyz0112
requested changes
Dec 31, 2018
| @@ -197,9 +200,10 @@ export function serializeNodeWithId( | |||
| n: Node, | |||
| doc: Document, | |||
| map: idNodeMap, | |||
| blockClass: string, | |||
There was a problem hiding this comment.
Now serializeNodeWithId has 5 params which I think it is a little hard for non-typescript users to use. How about refactoring it to one or two params which use object?
Closed
|
We are also interested in this functionality. @Yuyz0112 how can we help finish it? |
Yuyz0112
approved these changes
Apr 1, 2019
|
@marcospassos I just merged @samjbmason 's work and will address some code in the rrweb repo, then this feature will launch! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a passing of a
blockClassparameter to thesnapshotfunction, it will default torr-blockif none is provided.I have also fixed a broken spec by adding a class in the expected string.
This PR will fail until the above PR is merged. I can then bump the version in this package