-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
close #501 do not count attach iframe event in checkout
- Loading branch information
Showing
3 changed files
with
11 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
860ff38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
isAttachIframe
marker is only relevant during recording?Could we change it so that it's not part of the
mutationCallbackParam
type, e.g. make a new type (iFrameMutationCallbackParam
?) and then discard theisAttachIframe
attribute and coerce back tomutationCallbackParam
before emission?Or could it potentially be useful on the replay side?
(I'm trying to reason about how we can potentially batch up mutations during replay).
860ff38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eoghanmurray yes, we can discard the
isAttachIframe
attribute.