Skip to content

Commit

Permalink
chore: its important to run yarn build:all before running yarn dev
Browse files Browse the repository at this point in the history
  • Loading branch information
Juice10 committed Jun 10, 2024
1 parent 78849f3 commit c1d850f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Since we want the record and replay sides to share a strongly typed data structu

1. Fork this repository.
2. Run `yarn install` in the root to install required dependencies for all sub-packages (note: `npm install` is _not_ recommended).
3. Run `yarn dev` in the root to get auto-building for all the sub-packages whenever you modify anything.
3. Run `yarn build:all` to build all packages and get a stable base, then `yarn dev` in the root to get auto-building for all the sub-packages whenever you modify anything.
4. Navigate to one of the sub-packages (in the `packages` folder) where you'd like to make a change.
5. Patch the code and run `yarn test` to run the tests, make sure they pass before you commit anything. Add test cases in order to avoid future regression.
6. If tests are failing, but the change in output is desirable, run `yarn test:update` and carefully commit the changes in test output.
Expand Down
15 changes: 6 additions & 9 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"vite.config.defaults.ts",
"tsconfig.json"
],
"globalPassThroughEnv": ["CLEAR_DIST_DIR", "PUPPETEER_HEADLESS"],
"tasks": {
"prepublish": {
"dependsOn": ["^prepublish"],
Expand All @@ -21,22 +22,18 @@
]
},
"test": {
"dependsOn": ["^prepublish"],
"passThroughEnv": ["PUPPETEER_HEADLESS"]
"dependsOn": ["^prepublish"]
},
"test:watch": {
"persistent": true,
"passThroughEnv": ["PUPPETEER_HEADLESS"]
"persistent": true
},
"test:update": {
"dependsOn": ["^prepublish"],
"passThroughEnv": ["PUPPETEER_HEADLESS"]
"dependsOn": ["^prepublish"]
},
"dev": {
// "dependsOn": ["^prepublish"],
// "dependsOn": ["prepublish", "^prepublish"],
"persistent": true,
"cache": false,
"passThroughEnv": ["CLEAR_DIST_DIR"]
"cache": false
},
"lint": {},
"check-types": {}
Expand Down

0 comments on commit c1d850f

Please sign in to comment.