Crash once a http request ist send in Angular #167
Comments
|
Could you provide the code to reproduce this issus? |
|
Sadly no. I cant provide my code because its not a public project. |
|
I am also experiencing this, Angular 9. Totally locks Chrome tab. |
Are you using the npm module install or script? |
|
@24601 Do you have a reproducible code for this? |
|
Yes but I cannot share it publicly, so I will be happy to screen share
until I can pull out enough into a generic public example.
The issue seems related to http activity after recording begins so it’s not
as simple as making an angular template and just inserting record, as one
of our other background http proceeded causes it and I can’t just share
those.
…On Tue, Jun 23, 2020 at 01:57 yz-yu ***@***.***> wrote:
@24601 <https://github.com/24601> Do you have a reproducible code for
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#167 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI2QVZAN6SY3OOBU45TQWTRYBN7ZANCNFSM4KL5JYCA>
.
|
|
have the same issue with record function. Implementation: result: |
|
@kubadospial Do you have any reproducible code for me to debug? |
|
unfortunately I tried to reproduce the issue on new, clear angular 9 project and I wasn't able to. If I figure out what was the issue in my company project, I will follow up with it. |
|
@kubadospial I remember someone has reported they are having this issue with a tooltip component, are you using something like that in your project too? |
|
@Yuyz0112 yes we use a tooltip component in the app. In the free time I will remove this component and test if it helps. I will let you know |
This issue was originally reported in #280 but may also relate to #167 and other potential performance issues in the recording. In #206 I implemented the new mutation observer which will defer the serialization of DOM, which helps us to have a consistent DOM order for the replay. In this implementation, we use an array to represent the `addQueue`. Whenever we need to consume the queue, we will iterate it to make sure there is no dead loop, and then shift the first item to see whether it can be serialized at the new timing. But this implementation may be very slow when there are a lot of newly added DOM since it will do an O(n^2) iteration. For example, if we have three newly added DOM `n1`, `n2`, `n3`, the iteration looks like this: ``` [n1, n2, n3] n1 -> n2 -> n3, consume n3 [n1, n2] n1 -> n2, consume n2 [n1] n1, consume n1 ``` We should have a better performance if te iteration looks like this: ``` [n1, n2, n3] n3, consume n3 [n1, n2] n2, consume n2 [n1] n1, consume n1 ``` Simply reverse the mutation payload does not work, because it does not always as same as the DOM order. So in this patch, we replace the `addQueue` with a double linked list, which can: 1. represent the DOM order in its data structure 2. has an O(1) time complexity when looking up the sibling of a list item 3. has an O(1) time complexity when removing a list item
This issue was originally reported in #280 but may also relate to #167 and other potential performance issues in the recording. In #206 I implemented the new mutation observer which will defer the serialization of DOM, which helps us to have a consistent DOM order for the replay. In this implementation, we use an array to represent the `addQueue`. Whenever we need to consume the queue, we will iterate it to make sure there is no dead loop, and then shift the first item to see whether it can be serialized at the new timing. But this implementation may be very slow when there are a lot of newly added DOM since it will do an O(n^2) iteration. For example, if we have three newly added DOM `n1`, `n2`, `n3`, the iteration looks like this: ``` [n1, n2, n3] n1 -> n2 -> n3, consume n3 [n1, n2] n1 -> n2, consume n2 [n1] n1, consume n1 ``` We should have a better performance if te iteration looks like this: ``` [n1, n2, n3] n3, consume n3 [n1, n2] n2, consume n2 [n1] n1, consume n1 ``` Simply reverse the mutation payload does not work, because it does not always as same as the DOM order. So in this patch, we replace the `addQueue` with a double linked list, which can: 1. represent the DOM order in its data structure 2. has an O(1) time complexity when looking up the sibling of a list item 3. has an O(1) time complexity when removing a list item
|
#284 may relate to this issue. It's appreciated if anyone can help verify whether the issue still happen with v0.9.1. |
|
Please reopen this if there is any further information. |
|
Hello @kubadospial, |
|
It says was fixed in the commit 13f1a61. I've tried with angular 9, then upgraded to 10 and finally to 11. They all face the same result. Screen gets frozen. I've used the example code readme for the recording. I'm using ngx-bootstrap. This was done in Feb, was it truly fixed? |
|
@aserec Could you open a new issue and provide a reproducible code? |
I've been trying to get it to run in Angular and the events are coming but once its recording and im sending a web request Chrome just crashes the request never finishes and i cant do anything anymore.
Any suggestions?
The text was updated successfully, but these errors were encountered: