Use a custom Window object (aka: allow injection of rrweb from an iframe) #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can be tested with Tested with the following page: https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe |
samber
force-pushed
the
feat-custom-window
branch
from
a1313c0 to
c1b24e0
Compare
samber
force-pushed
the
feat-custom-window
branch
from
c1b24e0 to
82825d2
Compare
|
OK I think building this on top of #294 is the way forward, however gonna query the core team for the best approach i.e. whether it's better not to assume that all users want the topmost window |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for this awesome project 👏
Currently, rrweb does not allow recording a user session from an iframe. This is a bit annoying for those who run rrweb in a third-party tool injected as a Javascript tag.
I would like to suggest a different implementation of #294.
#294 offers to look up the top
Windowobject on the current page. This is a good start, but I would rather let the developer choose whatWindowHTML Element is the best:windoworwindow.toporwindow.parentorwindow.parent.parent.[...]ordocument.querySelector('iframe').contentWindow...PS: can anybody translate the doc to Chinese? 🙏