Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export recordOptions types #1067

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Export recordOptions types #1067

merged 1 commit into from
Jan 6, 2023

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Dec 7, 2022 •
edited
Loading

It would be very helpful to have recordingOptions properly exported. As of now, this is not part of entries/all.d.ts, which is generated, and is thus tree shaken away.

See getsentry/sentry-javascript#6448

Note to self: eventWithTime can be imported from @rrweb/types in v2.

@mydea mydea mentioned this pull request Dec 7, 2022
Closed
@mydea mydea changed the title Export eventWithTime and recordOptions types Export recordOptions types Dec 7, 2022
@YunFeng0817 YunFeng0817 merged commit b655361 into rrweb-io:master Jan 6, 2023
This was referenced Feb 12, 2023
Merged
Closed
Closed
Merged
This was referenced Jul 6, 2023
Closed
Closed
Closed
@billyvg billyvg mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunFeng0817 YunFeng0817 YunFeng0817 approved these changes

@Juice10 Juice10 Juice10 approved these changes

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @Juice10 @YunFeng0817