-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't have requestAnimationFrame looping in background for Live Mode #1098
Conversation
…- instead restart the loop when a new action is added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of code looks good to me.
} | ||
setTimeout(finish, finish_buffer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #1115, there will not be 'finish' event anymore in the liveMode. So IMO adding delay for all events won't be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the removal of this setTimeout implemented in #1115?
Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
Don't have requestAnimationFrame looping in background for Live Mode - instead restart the loop when a new action is added