Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't have requestAnimationFrame looping in background for Live Mode #1098

Merged
merged 6 commits into from
Feb 9, 2023

Conversation

eoghanmurray
Copy link
Contributor

Don't have requestAnimationFrame looping in background for Live Mode - instead restart the loop when a new action is added

Copy link
Member

@YunFeng0817 YunFeng0817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of code looks good to me.

packages/rrweb/src/replay/timer.ts Outdated Show resolved Hide resolved
}
setTimeout(finish, finish_buffer);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #1115, there will not be 'finish' event anymore in the liveMode. So IMO adding delay for all events won't be necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the removal of this setTimeout implemented in #1115?

Co-authored-by: Yun Feng <yun.feng0817@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants