Automate NPM package releases #1119
Conversation
| id: changesets | ||
| uses: changesets/action@v1 | ||
| with: | ||
| publish: yarn run release |
There was a problem hiding this comment.
I just want to make sure this command will publish the package directly or create a pull request first?
I feel that it's safer to create a pull request first rather than directly publish packages.
There was a problem hiding this comment.
It will create a PR first, once that PR is accepted it will publish the packages on NPM. Also if a PR already exists and more code is added to master the release command will update the PR with the new changes.
There was a problem hiding this comment.
I saw Matt's youtube video and I found that he only build the package here rather than publishing them. So I'm guessing ChangeSets will execute changesets publish for us rather than we manually do it?
There was a problem hiding this comment.
I tried that myself on https://GitHub.com/Juice10/rrweb and it didn’t work. Also looking at the changesets documentation and some projects using changesets this seems like the way to go. Looks like a mistake in Matt’s video
There was a problem hiding this comment.
Thanks for the explanation!
|
Changesets will really help us publish packages much faster. Currently, our publishing period is much longer than the average of npm packages. I believe this tool will change the situation. |
|
I think I've done the TODOs, feel free to ping me on slack or here if there is something missing. |
| @@ -36,15 +36,16 @@ export class RRWindow { | |||
|
|
|||
| export class RRDocument | |||
| extends BaseRRDocumentImpl(RRNode) | |||
| implements IRRDocument { | |||
| implements IRRDocument | |||
| { | |||
There was a problem hiding this comment.
These are formatting changes unrelated to changesets?
Use changesets to automate all npm package releases.
Todo before of after merge
NPM_TOKENEdit: for more info on how this works see #1119 (comment) or https://github.com/changesets/changesets