-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relative path detection in stylesheet URLs #1130
Conversation
🦋 Changeset detectedLatest commit: 210a02e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Juice10 @YunFeng0817 thanks for fixing the syntax errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Thanks for the contribution.
@Yuyz0112 can this be merged please? |
There can URLs with protocols other than HTTP / HTTPs / FTP
Example:
If you have loom installed in your browser, it adds some stylesheets that refer to
chrome-extension
protocolFor such URLs, rrweb is pre-pending the webpage origin in the CSS.
This PR is meant to make the relative URL detection more generic.
The regex I have added has been taken from stack overflow - https://stackoverflow.com/a/19709846
It checks for the existence of a protocol in the URL.