Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pref: export eventWithTime #1324

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

BelenLuo-tech
Copy link
Contributor

When using emit, you do not know the type of event and can only write it as any[], which is not very elegant. rrweb should provide the type directly

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 3b02af8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch
rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eoghanmurray
Copy link
Contributor

This is for consumption by another typescript programme?
Is this something that we could add to https://github.com/rrweb-io/rrweb/blob/master/docs/recipes/ or is it trivial?

@BelenLuo-tech
Copy link
Contributor Author

这是供另一个打字稿程序使用的吗? 这是我们可以添加到https://github.com/rrweb-io/rrweb/blob/master/docs/recipes/的东西还是微不足道的?

Just provide an accessible type that can be recorded without going to https://github.com/rrweb-io/rrweb/blob/master/docs/recipes/

@eoghanmurray eoghanmurray merged commit 1fe39ab into rrweb-io:master Oct 31, 2023
2 of 3 checks passed
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
*  export eventWithTime for consumption in typescript code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants