New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking: Avoid the repeated calls to `closest` when recursing through the DOM #1349

Merged

eoghanmurray merged 10 commits into rrweb-io:master from eoghanmurray:optimize-masking

Nov 24, 2023

Merged

Masking: Avoid the repeated calls to `closest` when recursing through the DOM #1349

Fixup eslint

GitHub Actions / ESLint Report Analysis succeeded Nov 15, 2023 in 2s

ESLint Report Analysis

0 ESLint error(s) and 11 ESLint warning(s) found in pull request changed files.
0 ESLint error(s) and 39 ESLint warning(s) found in files outside of the pull request.

Details

Annotations

Check warning on line 255 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L255

[@typescript-eslint/no-unused-vars] '_value' is defined but never used.

Check warning on line 393 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L393

[@typescript-eslint/no-unused-vars] 'isStylesheetLoaded' is defined but never used.

Check warning on line 558 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L558

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 647 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L647

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 647 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L647

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 741 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L741

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 742 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L742

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 743 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L743

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 744 in packages/rrweb-snapshot/src/snapshot.ts

github-actions / ESLint Report Analysis

packages/rrweb-snapshot/src/snapshot.ts#L744

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 347 in packages/rrweb/src/record/mutation.ts

github-actions / ESLint Report Analysis

packages/rrweb/src/record/mutation.ts#L347

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

Check warning on line 353 in packages/rrweb/src/record/mutation.ts

github-actions / ESLint Report Analysis

packages/rrweb/src/record/mutation.ts#L353

[@typescript-eslint/no-non-null-assertion] Forbidden non-null assertion.

View more details on GitHub Actions