-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "types" field to fix error when using "moduleResolution": "NodeNext" #1369
Add "types" field to fix error when using "moduleResolution": "NodeNext" #1369
Conversation
🦋 Changeset detectedLatest commit: 2d68597 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Any chance there's a maintainer that can take a look at this? Pretty please. 🥺 |
Thanks @stefansundin, this PR #1033 is also on the horizon which also fixes this. But I'm more then happy to get your version shipped asap |
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
…xt" (rrweb-io#1369) * Add "types" field to fix error when using "moduleResolution": "NodeNext". * Add changeset.
Hello,
In my project I am attempting to use
"moduleResolution": "NodeNext"
in mytsconfig.json
file, and importing rrweb types like this:But it results in this error:
After searching online and testing a few things, making the change in this PR made the error go away.
Please let me know if you want any other changes. Thanks!