Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export canvasMutation #1383

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jan 3, 2024

We are trying to support canvas playback without needing to remove the iframe sandbox (by enabling the UNSAFE_replayCanvas flag). Exposing this method would really help

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: d2c180f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/types Patch
@rrweb/web-extension Patch
rrvideo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Juice10
Copy link
Contributor

Juice10 commented Jan 4, 2024

This is very cool Daibhin, the rrweb team is really keen on adopting the whole solution to be pulled in for everyone to use. Would you be open to contributing the whole solution (as a plugin perhaps, or as part of regular rrweb)? I'd can personally lend a hand and make sure it lands in master.

@benjackwhite
Copy link
Contributor

This is very cool Daibhin, the rrweb team is really keen on adopting the whole solution to be pulled in for everyone to use. Would you be open to contributing the whole solution (as a plugin perhaps, or as part of regular rrweb)? I'd can personally lend a hand and make sure it lands in master.

This is 100% our intention. Main issue is we want to test this with a range of use cases first and we're blocked on that due to the missing export :D

Could we get this in first otherwise we will be stuck in a chicken-egg place 😉

@daibhin
Copy link
Contributor Author

daibhin commented Jan 17, 2024

Hi @Juice10. Sorry for the slow reply here, I'm just coming back from vacation. As @benjackwhite mentioned, would love to get this in first to properly test that everything works end to end locally before submitting a PR for a plugin.

One of the tests is failing with what seems to be an unrelated timeout. I don't seem to be able to rerun it. If we could get this in soon I'm hoping to spend the end of this week getting everything production ready.

@Juice10
Copy link
Contributor

Juice10 commented Jan 18, 2024

@daibhin yes master branch is broken currently but that'll be fixed soon so feel free to ignore it. Could you add a changeset, then I can merge this one

@daibhin
Copy link
Contributor Author

daibhin commented Jan 18, 2024

@Juice10 done. It's my first time working with changesets so let me know if I've done things correctly :)

@Juice10 Juice10 merged commit 1e0b273 into rrweb-io:master Jan 22, 2024
5 of 6 checks passed
@Juice10
Copy link
Contributor

Juice10 commented Jan 22, 2024

@daibhin You did it perfectly, merged! Thanks for the contribution, really looking forward to seeing the results of what you are working on.

@daibhin daibhin deleted the dn-chore/export-canvas-mutation branch January 22, 2024 15:37
jaj1014 pushed a commit to pendo-io/rrweb that referenced this pull request Apr 30, 2024
* chore: export canvasMutation

* add changeset
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
* chore: export canvasMutation

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants