Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the test CI #1405

Merged
merged 2 commits into from
Jan 28, 2024
Merged

fix the test CI #1405

merged 2 commits into from
Jan 28, 2024

Conversation

Yuyz0112
Copy link
Member

After investigating the current CI actions, there are two common errors in the failed test workflows:

  1. puppeteer timeout
  2. rrdom tests failed in missing rpt2 cache

Since we have many e2e tests running in puppeteer, and turbo parallel all the test tasks by default, it may cause a relatively large number of puppeteer instances in the CI env, which causes perf issues and makes the tests unstable.
So I set the concurrency of test tasks to 1.

For the rpt2 cache, I think it's because we have multiple compileTSCode calls in different test files, and jest also runs tests parallel by default.
Instead of setting jest to disable concurrency, I change the compileTSCode to not use cache.

These changes may slow down our test workflows but should make it work stable again. But I believe we can greatly improve test performance(also build performance) by enabling turbo cache in the CI env.

Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 583f05a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Yuyz0112 Yuyz0112 merged commit fc2feee into master Jan 28, 2024
11 checks passed
@Juice10 Juice10 deleted the yz-patch-1 branch February 1, 2024 11:37
jaj1014 pushed a commit to pendo-io/rrweb that referenced this pull request Apr 30, 2024
* run tests without concurrency

* do not use cache in rpt2 during test
jxiwang pushed a commit to amplitude/rrweb that referenced this pull request Jul 31, 2024
* run tests without concurrency

* do not use cache in rpt2 during test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants