Fix and test for bug #1457 #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ression too large) - see test case which is extracted from a real world css file; the selector regex was able to traverse the curly brace as when looking for quotes, it wasn't taking into account that the start quote could be escaped
🦋 Changeset detectedLatest commit: de2363a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced May 20, 2024
… a url - need to consume quotes. Thanks dave.kindel@pendo.io for reporting and isolating this case
Juice10
approved these changes
May 22, 2024
Merged
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Sep 6, 2024
Merges the following commits: * [Ensure there is separation of timestamps](rrweb-io#1455) * [perf(snapshot): avoid recreate element a every time](rrweb-io#1387) * [Fix that blob urls persist on the shared anchor element and can't be later modified](rrweb-io#1467) * [yarn format - prettier improvements & add .editorconfig](rrweb-io#1471) * [Fixup for background-clip replacement](rrweb-io#1476) * [Fix and test for bug](rrweb-io#1481)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Uncaught SyntaxError: Regular expression too large in #1457