Code

Fix performance of splitCssText #1615

Code

Open

eoghanmurray wants to merge 26 commits intorrweb-io:masterrrweb-io/rrweb:masterfrom eoghanmurray:fix-1603eoghanmurray/rrweb:fix-1603Copy head branch name to clipboard

+122-15

Commits

Commits on Dec 18, 2024

• Fix bug where the right split point was not being picked for the 3rd section onwards

  eoghanmurray

  committed
  eaec68a

• Add test to put splitCssText through it's paces with a large file

  eoghanmurray

  committed
  0610a7b

• Introduce a limit which causes the 'efficiently' test to fail

  eoghanmurray

  committed
  d99fc8f

• Fix that it wasn't able to find a split when both halves were identical

  eoghanmurray

  committed
  8afdc43

• Fix poor 'crawling' performance in this part of the algorithm for large css texts - e.g. for a (doubled) benchmark.css, we were running normalizeCssText 9480 times before k got to the right place

  eoghanmurray

  committed
  ea1b11b

• Need to take larger jumps to be efficient; use the scaling factor to make better guess at how big a jump to make

  Show description for 2efb8aa
  eoghanmurray

  committed
  2efb8aa

• Add changeset

  eoghanmurray

  committed
  76e33d3

• Presuming the match on a character is more eficient than the indexOf here

  eoghanmurray

  committed
  339ecdb

• Fix eslint

  eoghanmurray

  committed
  543ad6b

Commits on Dec 19, 2024

• Update puppeteer to try to solve the following issue in github actions:

  Show description for 729c3f3
  eoghanmurray

  committed
  729c3f3

• Bump Chrome to see if it solves following issue in github actions:

  Show description for 6620259
  eoghanmurray

  committed
  6620259

Commits on Dec 20, 2024

• Both Firefox and the 131 version of Chrome I've upgraded to remove default css values from shorthand properties when retrieved via sheet.rules[0].cssText

  eoghanmurray

  committed
  9693697

• Drop chrome down again as getting overwhelmed with issues so will see if this LTS version also solves:

  Show description for 6d3047a
  eoghanmurray

  committed
  6d3047a

• Bump all puppeteer to match the LTS version of chrome we've just specified - going by https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

  eoghanmurray

  committed
  76cca31

• Fix json error

  eoghanmurray

  committed
  6522c7d

• The previous version combo didn't install, trying next one up

  eoghanmurray

  committed
  8ca3c5d

Commits on Dec 22, 2024

• Still getting 'zygote_host_impl_linux.cc(128)] No usable sandbox!' so iterating through versions

  eoghanmurray

  committed
  f937245

• Keep searching through https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

  eoghanmurray

  committed
  2ca2c2d

• Following https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

  eoghanmurray

  committed
  0384b23

• Continuing with https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md

  eoghanmurray

  committed
  a8a10c0

Commits on Dec 30, 2024

• Another bump to find minimum version to remove the 'No Usable Sandbox' error

  eoghanmurray

  committed
  33e0410

• Final bump to top of https://github.com/puppeteer/puppeteer/blob/5d72c7d3c3e9c8cd53bcb4b597a0924dced1b5fc/docs/supported-browsers.md

  eoghanmurray

  committed
  8b0674e

• Further bump of Chrome as issue still isn't solved - this previously seemed to solve things

  eoghanmurray

  committed
  6dda0ac

Commits on Jan 2, 2025

• Think that the ubuntu upgrade is what is affecting the tests: actions/runner-images#10636

  eoghanmurray

  committed
  c8b0595

• Revert all puppeteer and chrome related changes as the problem was fixed with runs-on: ubuntu-22.04

  eoghanmurray

  committed
  e7f362c

Commits on Jan 4, 2025

• I keep accidentally forgetting camelCase

  eoghanmurray

  committed
  e5f22e3