Relative server url #1765
Closed
Relative server url #1765
+9,420
−1,223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlink:href is deprecated Most modern browsers rewrite `xlink:href` to `href` which is currently supported Tested in Firefox, Safari & Chrome
AssetManager.manageAttribute
different types of assets (not just img#src)
Co-authored-by: Eoghan Murray <eoghan@getthere.ie>
…the AssetManager needs to interrogate other attributes to determine how to manage, e.g. <link with href depending on rel="stylesheet"
…tributes instead of storing config on the Meta event - a better approach as discussed with Justin and Yanzhen
…n determine that Assets won't be arriving later
…e existing nested iframe mechanism
…ic types that inline images or pdfs
…cipating we'd still do one last POST attempt at the end of the page lifecycle
…int, instead of just the keys/values payload
…a event on every emit as we tried to recreate the connection
…r, and didn't anticipate it firing every time a connection failed
…e can demonstrate the POST url taking over
…ts back here) - in any case `.ok` is well known and supported
…ngest endpoint can handle / special case those recording-meta events
…hem around it so that we can remember to reset global state
🔧 improve how fallback from websockets to POST works. Add a public stop function
…oyed to multiple domains
🦋 Changeset detectedLatest commit: 9ee4729 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow relative urls in the case where a single build needs to be deployed to multiple domains