feat: enable rrweb to record and replay log messages in console #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hijack all of the console functions. add listener to thrown errors
add limit to the max number of log records
this is the implementation of new feature request(issue #234) here are a few points of description. 1. users need to set recordLog option in rrweb.record's parameter to record log messages. The log recorder is off by default. 2. support recording and replaying all kinds of console functions. But the reliability of them should be tested more 3. the stringify function in stringify.ts needs improvement. e.g. robustness, handler for cyclical structures and better support for more kinds of object 4. we can replay the log messages in a simulated html console like LogRocket by implementing the interface "ReplayLogger" in the future
1. handle cyclical structures 2. add stringify option to limit the length of result 3. handle function type
|
@Yuyz0112 Could you please review this pull request😂 I've solved merge conflicts two times in the past one week |
Yuyz0112
reviewed
Nov 29, 2020
src/types.ts
Outdated
| }; | ||
|
|
||
| // functions to replay log record | ||
| export type ReplayLogger = { |
There was a problem hiding this comment.
export type ReplayLogger = Record<LogLevel, (data: logData) => void>Is this an equivalent?
There was a problem hiding this comment.
Yes, this one is better!
|
LGTM Most of the design looks great and just a few things need to be tweaked. |
|
There is no easy way to transmit events for when an unhandled exception happens on the page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the implementation of new feature request(issue #234 )(issue #317 )
here are a few points of description.