Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid runtime error when CSSGroupingRule is not supported #693

Merged

Conversation

yukukotani
Copy link
Contributor

@yukukotani yukukotani commented Sep 9, 2021

ad-hoc fix for #690.

Copy link
Contributor

@Juice10 Juice10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR fixes the safari error for #690 but doesn’t re-add support for nested styles to safari, so we’ll have to add that in a separate PR. More info: #690 (comment)

@yukukotani
Copy link
Contributor Author

@Juice10 Yes, this is just an ad-hoc patch to avoid runtime errors!

@Yuyz0112
Copy link
Member

Yuyz0112 commented Sep 9, 2021

Thanks!

@Yuyz0112 Yuyz0112 merged commit 5b40470 into rrweb-io:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants