Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues:
fixEDIT: this solution was not good, see the commentsimg.complete
being false, which breaks inline image feature completelyIt seems that immediately after you set
image.crossOrigin = 'anonymous'
the image becomes "not loaded yet", which breaks the logic. It's easy to check just by adding a quickconsole.log('IMAGE:', img, img.complete, img.naturalWidth, img.naturalHeight)
just before this if condition:rrweb/packages/rrweb-snapshot/src/snapshot.ts
Lines 534 to 535 in b0dc388
I moved that logic just before we call
toDataURL()
just like this article says: https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_imageremove
srcset
which overwrites thesrc
and breaks restoring images that havesrcset
ping @Mark-Fenng because you have the context of this feature from previous PR.