Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable virtual parent optimization on <head> #827

Closed

Conversation

eoghanmurray
Copy link
Contributor

Was experiencing an issue where the virtual parent optimization was destroying already applied styles during mutations

…estroying already applied styles during <head> mutations
@eoghanmurray eoghanmurray force-pushed the no-virtual-parent-on-head branch from 87f303c to 9949db9 Compare February 4, 2022 18:27
…ent a new parent from using virtual parent, then any new children get lost
@eoghanmurray
Copy link
Contributor Author

Re. b27789e I managed to patch over the failing test by also cancelling the virtual parent optimization for subsequent adds if any or under ... however I didn't figure out why exactly it wasn't working, and the solution in b27789e is likely brittle.

Hopefully this is okay as the virtual parent optimization is slated for removal.

@eoghanmurray
Copy link
Contributor Author

eoghanmurray commented Mar 3, 2022

OK so I couldn't create a test in order to recreate this!
I also couldn't recreate it by reverting our codebase.
The changeset here definitely fixed it for us at the time, but I'm happy to let this fade away given that this optimization is going to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant