Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: v0.2.0 Deepbinner bin - "readclass not found" #11

Open
rekm opened this issue Oct 11, 2018 · 3 comments
Open

Bug: v0.2.0 Deepbinner bin - "readclass not found" #11

rekm opened this issue Oct 11, 2018 · 3 comments

Comments

@rekm
Copy link

rekm commented Oct 11, 2018

I am running deepbinner bin on already basecalled minion data.
The tool throws a KeyError("not found"), if an unclassified read id is encountered.

Data:
Flow-Cells: FLO-MIN106
Kit: SQK-RBK004

Classification was generated per run with:

deepbinner classify --rapid p_root/fast5/pass/{R_num}  1> {output} 2> {log}

Binning with:

deepbinner bin --classes {input.classi} --reads {input.pass_fastq} --out_dir {outdir}

For some runs the classification omits one read and this prompts the bin.py to switch into a previously untested or disabled section of code.

Maybe I just have an old version of the code.

enable_not_found_bin_patch.txt

jdeligt added a commit to jdeligt/Deepbinner that referenced this issue Jul 4, 2019
This is referring to the issue reported here rrwick#11.
I encountered this error myself and made this quick fix to get the program to finish.
@rwick Might be good to incorporate a fix since it currently dies rather suddenly.

I haven't figured out yet why the reads (I've got 587 out of 2.4 mil) are not being classified in the first place (the couple that I blasted seem like real data). If I figure it out I'll report in a separate "non classified reads" issue about this.
@jrherr
Copy link

jrherr commented Jul 29, 2019

Any chance this pull request will be merged anytime soon?

I have a large run (380GB of fast5) where I'm not done calling bases, but I want to take the (120GB) of fastq files I have base called already and debarcode them. It's throwing the KeyError("not found") for those fastq files not base called from the fast5 files yet.

@ttubb
Copy link

ttubb commented Aug 5, 2019

jrherr i dont know if this is a suitable solution for you, but:
If you have acquired deepbinner using git, you can merge the hotfix into your local repository using:
git pull origin pull/30/head

In case you need a docker container, i have just added the above line to mine. Its on Docker Hub: https://hub.docker.com/r/ttubb/deepbinner/dockerfile (currently waiting on Docker Hub to build the updated version, should be done in a few hours).

@jrherr
Copy link

jrherr commented Aug 12, 2019

Thanks @ttubb! I needed a couple of days to implement, but this worked like a charm!

I did exactly as you said, merged the hotfix, and reinstalled deepbinner using pip. Worked great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants