Use re.search() when checking java version #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`re.MULTILINE` doesn't work with re.match().
|
Thanks for this! I've merged it into Unicycler's development branch, which is where I put stuff prior to the next release. It will end up in the master branch when I accumulate enough changes for a new release. Ryan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
$_JAVA_OPTIONSto set some global options for all java tools that run under Galaxy, but this causes the first line of java's output to be:Picked up _JAVA_OPTIONS: -Dfoo ..., which caused the version check to fail since re.MULTILINE doesn't work with re.match(), it just happened to work in most cases since in most cases, the first line of stderr was always the version line.