some groundwork for peer/content discovery #256

ljedrz · 2020-07-21T15:08:23Z

Some groundwork for peer and content discovery using libp2p::kad.

~~Very much a WIP with plenty of prototyping and wild println!s.~~

Cc #10

Signed-off-by: ljedrz <ljedrz@gmail.com>

src/lib.rs

koivunej · 2020-07-22T12:40:44Z

src/lib.rs

@@ -608,6 +616,35 @@ impl<Types: IpfsTypes> Ipfs<Types> {
        rx.await?
    }

+    pub async fn bootstrap(&self) -> Result<(), Error> {


Suggested change

pub async fn bootstrap(&self) -> Result<(), Error> {

// Initiate a query for random key to discover peers.

pub async fn bootstrap(&self) -> Result<(), Error> {

Is there a reason for this to be in the API or is it only while we are not doing this periodically ourselves?

I don't know if we are doing it at all automatically; I can check

doesn't seem that way, at least not in tests

No we are not yet doing it automatically, but we probably should eventually.

What is the reason for exposing this as a method? Does kad queue these bootstraps or are they executed concurrently?

Does kad queue these bootstraps or are they executed concurrently?

good question; I don't know, but I'd expect it to be concurrent; a single call can result in a few logs that the bootstrapping query has completed

http/src/main.rs

src/p2p/behaviour.rs

src/lib.rs

src/p2p/behaviour.rs

Signed-off-by: ljedrz <ljedrz@gmail.com>

src/lib.rs

…_generated_keys Signed-off-by: ljedrz <ljedrz@gmail.com>

Signed-off-by: ljedrz <ljedrz@gmail.com>

Co-authored-by: Joonas Koivunen <joonas.koivunen@gmail.com> Signed-off-by: ljedrz <ljedrz@gmail.com>

… names Signed-off-by: ljedrz <ljedrz@gmail.com>

Signed-off-by: ljedrz <ljedrz@gmail.com>

koivunej

Looking good, thanks! bors r+

koivunej · 2020-07-22T14:01:53Z

bors r+

256: some groundwork for peer/content discovery r=koivunej a=ljedrz Some groundwork for peer and content discovery using `libp2p::kad`. ~~Very much a WIP with plenty of prototyping and wild `println!`s.~~ Cc #10 Co-authored-by: ljedrz <ljedrz@gmail.com>

bors · 2020-07-22T14:19:46Z

Build failed:

ci

koivunej · 2020-07-22T14:23:25Z

I dont think anything changed with the bitswap so that's probably a transient one.

bors retry

bors · 2020-07-22T14:40:31Z

Build succeeded:

ci

feat: initial Kademlia extensions

8e957c2

Signed-off-by: ljedrz <ljedrz@gmail.com>

ljedrz force-pushed the content_discovery branch from b325b9b to 6428df5 Compare July 22, 2020 09:37

ljedrz added 2 commits July 22, 2020 12:00

feat: add and test peer discovery

3bb0a65

Signed-off-by: ljedrz <ljedrz@gmail.com>

fix: update a few tests

e2297fd

Signed-off-by: ljedrz <ljedrz@gmail.com>

ljedrz force-pushed the content_discovery branch from 6428df5 to e2297fd Compare July 22, 2020 11:32

ljedrz marked this pull request as ready for review July 22, 2020 11:32

ljedrz requested a review from koivunej July 22, 2020 11:32