Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Improved interop test functionalities, prepare a simple pubsub interop test #369

Merged
merged 7 commits into from
Sep 11, 2020

Conversation

ljedrz
Copy link
Member

@ljedrz ljedrz commented Sep 11, 2020

Builds on #368, only the test: ... commits are new.

Extends the interop test functionalities so that arbitrary HTTP API calls can be made for the foreign nodes; I attempted to use them in order to introduce a pubsub interop test, but it doesn't work yet. Since the underlying issue might cause the PR to grow, I'd prefer to merge it as-is, with the new pubsub interop test currently #[ignore]d.

Blocked by #368.

Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
Signed-off-by: ljedrz <ljedrz@gmail.com>
@ljedrz ljedrz requested a review from aphelionz September 11, 2020 14:56
Signed-off-by: ljedrz <ljedrz@gmail.com>
Copy link
Contributor

@aphelionz aphelionz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Sep 11, 2020
369: Improved interop test functionalities, prepare a simple pubsub interop test r=aphelionz a=ljedrz

Builds on #368, only the `test: ...` commits are new.

Extends the interop test functionalities so that arbitrary HTTP API calls can be made for the foreign nodes; I attempted to use them in order to introduce a `pubsub` interop test, but it doesn't work yet. Since the underlying issue might cause the PR to grow, I'd prefer to merge it as-is, with the new `pubsub` interop test currently `#[ignore]`d.

Blocked by #368.

Co-authored-by: ljedrz <ljedrz@gmail.com>
@bors
Copy link
Contributor

bors bot commented Sep 11, 2020

Build failed:

@aphelionz
Copy link
Contributor

bors retry

@bors
Copy link
Contributor

bors bot commented Sep 11, 2020

Build succeeded:

@bors bors bot merged commit 4cdc096 into rs-ipfs:master Sep 11, 2020
@ljedrz ljedrz deleted the pubsub_interop branch September 11, 2020 16:20
@ljedrz
Copy link
Member Author

ljedrz commented Sep 11, 2020

Cc #132

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants