Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

feat: (re)enable mdns #474

Closed
wants to merge 1 commit into from

Conversation

Mirko-von-Leipzig
Copy link
Contributor

This PR re-enables mDNS support. This was disabled in PR #446, due to libp2p removing tokio support for it. The support has since been added back so this should work again.

This was disabled in PR rs-ipfs#446, due to libp2p removing tokio support for
it. The support has since been added back so this should work again.

rs-ipfs#446
@Mirko-von-Leipzig
Copy link
Contributor Author

Mirko-von-Leipzig commented Aug 30, 2021

Note that this requires the libp2p feature mdns, which brings in the async-io dependency

@koivunej
Copy link
Collaborator

koivunej commented Aug 31, 2021

I haven't had much to time for rust-ipfs recently but to summarize our discussion on the current impl of libp2p-mdns; it still introduces unconditionally async-io, so the original reason for ugly commenting out has not changed. My original plan was to look into how libp2p-tcp was kept compatible for both runtimes and use that over at -mdns. I still think we should look into restoring the functionality in upstream before re-enabling the feature over at rust-ipfs.

@koivunej koivunej closed this Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants