Support .cif inputs as alternatives to .pdb
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows all three
matchmapsutilities to take accept input starting models in either.pdb. or.cifformats. The.cifformat is increasingly common / preferred as the file type for macromolecular structures, so this is good to support going forward.In order to preserve as much existing code as possible, this change is implemented via a
_cif_or_pdb_to_pdb()helper function. When given a.pdbinput file, this function simply copies that file over to the output directory. When given a.cifinput file, this function reads the file into python (viagemmi) and then writes out an analogous.pdb-formatted file into the output directory.Structure factor
.cifs are not yet supported.