Fix crash when --input-dir
and --output-dir
match
#39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #38,
matchmaps
crashes when the specified input and output directories do not match (most likely because neither is specified and they both default to./
). This PR fixes this behavior by wrapping the offendingshutil.copy()
call in atry
/except
block. A message is printed to the user noting that the input and output directories match, and that while this is acceptable, it is not the recommended directory structure.I have confirmed for all three command-line utilities that there are no unexpected consequences downstream of this behavior.