Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action for testing documentation build during pull requests #207

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

JBGreisman
Copy link
Member

This PR adds a GitHub Action workflow that builds the static documentation site using sphinx. This addresses a lingering issue that the documentation build is only attempted upon merging into the main branch. This way we can catch issues before merging.

This workflow is equivalent to the documentation build, but any changes are not added to the gh-pages branch and the site itself is not updated.

@JBGreisman JBGreisman added the documentation Issue related to documentation label Feb 20, 2023
@JBGreisman
Copy link
Member Author

This problem was raised by #202, where merging a new PR led to a new version of jinja2 being used for building the documentation. This was not caught by our build tests of the PR, and was only realized when the site build failed.

@JBGreisman JBGreisman merged commit 9294621 into main Feb 20, 2023
@JBGreisman JBGreisman deleted the testdocs branch February 20, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant