Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support **kwargs in gemmification decoratored fn #247

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

kmdalton
Copy link
Member

This PR modifies the @spacegroupify and @cellify decorators so as to support decorating functions which take arbitrary keyword arguments (**kwargs). Specifically, it alters the usage of the BoundArguments instance in the decorated function call.

f(**bargs.arguments) becomes f(*bargs.args, **bargs.kwargs)

@kmdalton kmdalton requested a review from JBGreisman March 11, 2024 19:17
@kmdalton kmdalton added the bug Something isn't working label Mar 11, 2024
Copy link
Member

@JBGreisman JBGreisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- makes sense to update these decorators to fully support arbitrary keyword arguments

@JBGreisman JBGreisman merged commit 8631a99 into main Mar 17, 2024
6 checks passed
@JBGreisman JBGreisman deleted the decorator_sig branch March 17, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants