Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set maximum numpy version to <2.0 #256

Closed
wants to merge 1 commit into from
Closed

set maximum numpy version to <2.0 #256

wants to merge 1 commit into from

Conversation

kmdalton
Copy link
Member

numpy version 2.0 is breaking a bunch of tests. We should set a maximum version number until we can diagnose the issues.

To replicate:

conda create -yn rs python=3.11
conda activate rs
git clone https://github.com/rs-station/reciprocalspaceship
cd reciprocalspaceship
pip install -e . 
python setup.py test

@kmdalton kmdalton requested a review from JBGreisman June 17, 2024 19:09
@JBGreisman
Copy link
Member

Do you still think this is necessary to include, or should we close this in favor of #258?

@JBGreisman
Copy link
Member

I'm closing this in favor of #258 based on our off-line discussion

@JBGreisman JBGreisman closed this Jun 18, 2024
@kmdalton kmdalton deleted the numpy_version branch September 11, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants