New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Numpy v1 Support #261

Merged

kmdalton merged 3 commits into main from npv1

Jun 25, 2024

Member

kmdalton commented Jun 24, 2024

The goal of this pr is to

restore numpy v1 support which was broken by enable numpy 2.0 support #258
modify the CI to build against numpy v1 and v2

Kevin Dalton added 3 commits

June 24, 2024 15:01


          fix numpy v1 support

88f1caa


          add numpy v1 to matrix

df663cd


          fix numpy versioning

69ed824

kmdalton requested a review from JBGreisman

June 24, 2024 19:27

JBGreisman approved these changes

View reviewed changes

Member

JBGreisman left a comment

This looks good to me -- seems good to maintain compatibility wherever possible, and I like the expansion of the test suite around numpy versions.

kmdalton merged commit f8765bf into main

8 of 14 checks passed

kmdalton deleted the npv1 branch

June 25, 2024 13:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet