add option to allow all methods #120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@contrun Good idea; that would indeed be useful. Do you have any interest (even after so long) in resolving your branch's conflicts? Otherwise, I'm considering submitting my own PR. |
contrun
force-pushed
the
allowed-methods-all
branch
from
3a53db5
to
5365f5c
Compare
|
@jub0bs I rebased my commit. |
|
@contrun Looks good, but could you add a couple of test cases to cover this new functionality? I think the maintainer would likely merge the PR then. |
|
@contrun Are you still interested in this contribution? If so, will you have time to add a few test cases for it? |
|
@jub0bs Sorry I don't have time to do this. Please submit your own PR. Thanks. Feel free to close this one. |
|
@contrun No worries; I just wanted to know. Someone else can take it from here. Thanks for contributing the idea and this PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a wildcard option
*to allow all methods specified inAccess-Control-Request-Method. I was trying to access webdav files from organice. My preflight request is like thiscurl -vvvvvv -H 'Access-Control-Request-Method: PROPFIND' -H 'Access-Control-Request-Headers: authorization,depth' -H 'Origin: https://organice.200ok.ch' -X OPTIONS http://example.com. There is a few custom http verbs for webdav. I think it makes sense to allow all the http methods, so I added an option to allow all methods, just like the option to allow all http headers.