Revert "fix headers/body order (#55)" #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e63e657. The commit above introduced sane-ordering to the terminal output by prioritizing headers first and then the response body. But unfortunately it introduces a deadlock in cases where we have no headers to print. Commands like `curlie` or `curlie -h` will hang. Sometimes it also causes the program to deadlock even when headers are present. It probably has something to do with the code failing to properly detect where the headers' section ends. But this is difficult to reproduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #55.
The pull request above introduced sane-ordering to the terminal output by prioritizing headers first and then the response body. But unfortunately it introduces a deadlock in cases where we have no headers to print.
Simple commands like
curlieorcurlie -hwill hang.Sometimes it also causes the program to deadlock even when headers are present. It probably has something to do with the code failing to properly detect where the headers' section ends. But I'm having difficulty reliably reproducing this case.
Fixes #72
Fixes #73